Fix MsQuicConfiguration.GetConfigurationCacheEnabled (dotnet#101555)

michaelgsharp · May 8, 2024 · baf1ea1 · baf1ea1
1 parent 84a209d
commit baf1ea1
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/src/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicConfiguration.Cache.cs b/src/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicConfiguration.Cache.cs
@@ -21,22 +21,23 @@ internal static partial class MsQuicConfiguration
     private const string DisableCacheCtxSwitch = "System.Net.Quic.DisableConfigurationCache";
 
     internal static bool ConfigurationCacheEnabled { get; } = GetConfigurationCacheEnabled();
+
     private static bool GetConfigurationCacheEnabled()
     {
         // AppContext switch takes precedence
         if (AppContext.TryGetSwitch(DisableCacheCtxSwitch, out bool value))
         {
             return !value;
         }
-        else
+        // check environment variable second
+        else if (Environment.GetEnvironmentVariable(DisableCacheEnvironmentVariable) is string envVar)
         {
-            // check environment variable
-            return
-                Environment.GetEnvironmentVariable(DisableCacheEnvironmentVariable) is string envVar &&
-                !(envVar == "1" || envVar.Equals("true", StringComparison.OrdinalIgnoreCase));
+            return !(envVar == "1" || envVar.Equals("true", StringComparison.OrdinalIgnoreCase));
         }
-    }
 
+        // enabled by default
+        return true;
+    }
     private static readonly ConcurrentDictionary<CacheKey, MsQuicConfigurationSafeHandle> s_configurationCache = new();
 
     private readonly struct CacheKey : IEquatable<CacheKey>