Add PHP domain. #351
Merged
Add PHP domain. #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay. The changes look good, especially making it all optional. I couldn't find a quick test project for PHP, but current functionality isn't changed. Possible edge cases are future issues, this is a good start. If you ever have some time feel free to submit some test cases, thank you. |
vermeeren
added
enhancement
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this pull request tries to add support for Sphinx PHP domain, using sphinxcontrib-phpdomain==0.2.5 package (when available).
Regards,
Przemek Czerkas