Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Mike,
decorator-decorated methods can't be cythonized because cyfunctions are evaluated to False with
inspect.isfunction()
. However, necessary inspection elements for decorator-decoration can be carried out okay as long asinspect.isroutine()
is evaluated to True.So I would like to suggest to replace the test in the
FunctionMaker
to useinspect.isroutine()
. I tested cythonizing a fairly complex proprietary ipython magic class, and it works well.