-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binary data gets garbaged #11
Comments
Enabling the UTF8 flag on BinaryPack constructor this seems to be fixed. |
I actually cannot reproduce this. Are you converting your image to a string first? |
Yes, I'm moving JSON strings.
|
Why not just directly send JSON objects with Blobs? Binarypack takes care Michelle On Thu, May 2, 2013 at 10:58 PM, Jesús Leganés Combarro <
|
It's probably good to just build in utf8 as an option for reliable, because |
Maybe it's my fault :-) I'm using JSON on my project since begin 9 months
|
Maybe it's the reason why it's so slow for me?
|
http://kentonv.github.io/capnproto/ At last found it :-P I didn't remember the name, but I was thinking about
|
Cap'n Proto was designed with static languages in mind and IMO has little place in Javascript if we're not involving any other lower level languages. The biggest issue I see with it is that it requires a schema--for something like PeerJS it would introduce unnecessary overhead. BinaryPack is actually a modified version of MessagePack, which is pretty widely adopted as a web serialization format. |
MessagePack and its improved cousin BinaryPack seems to be better 2013/5/3 Michelle Bu [email protected]
"Si quieres viajar alrededor del mundo y ser invitado a hablar en un monton |
Yeah basically there's no need to convert your file blob into a binary On Fri, May 3, 2013 at 4:02 PM, Jesús Leganés Combarro <
|
When trying to send an image of just some KB, the content gets converted to a sequence of escaped Unicode glyphs ("u1234") getting a transfered size sometimes more than double bigger, and worst than that, message gets truncated because of the extra size. For text files (for example HTML) there's not this problem.
The text was updated successfully, but these errors were encountered: