Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support default dark theme in sources panel in Chrome v50 #112

Closed
micjamking opened this issue Feb 7, 2016 · 1 comment · Fixed by #117
Closed

Support default dark theme in sources panel in Chrome v50 #112

micjamking opened this issue Feb 7, 2016 · 1 comment · Fixed by #117

Comments

@micjamking
Copy link
Owner

In Chrome Version 50.0.2642.0 canary (64-bit); there is a default 'dark' theme available, skinning all panels in DevTools with a Dark theme.

screen shot 2016-02-03 at 12 06 36 pm

DevTools Author works out of the box with the new dark themes, only targeting code-view and console panels within DevTools and targeting syntax highlighting within that.

However, DevTools Author also skins the sidebar panel using a slightly lighter 'gray' background color, which directly impacts the legibility within the sources view

screen shot 2016-02-06 at 4 55 22 pm

It looks like the new DevTools themes use a body class of .-theme-with-dark-background to add styles, so adjusting the support for v50 should be fairly straightforward.

Reference Issues: #31

@micjamking micjamking self-assigned this Feb 7, 2016
@micjamking micjamking added this to the 1.0 milestone Feb 7, 2016
@micjamking micjamking added bug and removed bug labels Feb 7, 2016
@micjamking
Copy link
Owner Author

If possible, it would be nice to also skin the Author Settings panel to use a dark background when the 'dark' parent theme is applied.

screen shot 2016-02-06 at 5 09 18 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant