-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Darcula #97
Comments
@klimashkin here is a perfect place to request new themes! If you can locate the color palette (hex or RGB) I can try to recreate the theme. The match may not be perfect since Devtools itself has theming restrictions, but we can probably get pretty close. |
I think I found some hex values for the theme. I'm happy to take a stab at it! |
@bolensmichael go for it! Feel free to make a PR that references this issue (#97) when you're done. |
Awesome work by @bolensmichael! This is in release v0.5.7 c8d9064 |
@klimashkin I'm not sure where @bolensmichael found the color palette values for the theme, but it does appear the syntax highlighting itself is a bit off. I mentioned this in my original comment here: #97 (comment), but something to note is that DevTools itself does have some theming restrictions which may prevent 100%, 1-to-1 mapping of the themes from another IDE. The Darcula theme is available here: https://github.com/micjamking/devtools-author/blob/master/app/styles/themes/darcula.scss. Any additional styles needed to improve the syntax highlighting accuracy for a specific theme can be added to the bottom of that theme file. If you'd like, you can contribute changes by following the steps on the README and make a pull request. ✌️ |
Hi @klimashkin sorry it's not exactly right. I was going based off of the images and color codes on the site here http://eclipsecolorthemes.org/?view=theme&id=14569 since you didn't provide the hex scheme and matched it pretty much identically to what is displayed there. The groundwork for the theme is now merged in, so feel free to swap the colors in that you'd prefer them to be! |
I don't know if here a good place to request new theme.
Many developers work with Jetbrains Darcula theme in theirs Webstorm/phpstorm etc. Good to have it in devtools also!
The text was updated successfully, but these errors were encountered: