Merge pull request braintree#84 from braintree/feature/new-line-at-en…

…d-of-file

Add a new-line at the end of every file to support merchant integrations with GCC_WARN_ABOUT_MISSING_NEWLINE

Braintree.podspec

@@ -22,7 +22,7 @@ Pod::Spec.new do |s|
   s.source_files     = "Braintree/*.{m,h}"
 
   s.compiler_flags = "-Wall -Werror -Wextra"
-  s.xcconfig = { "GCC_TREAT_WARNINGS_AS_ERRORS" => "YES" }
+  s.xcconfig = { "GCC_TREAT_WARNINGS_AS_ERRORS" => "YES", "GCC_WARN_ABOUT_MISSING_NEWLINE" => "YES" }
 
   s.default_subspecs = %w[Drop-In API PayPal Venmo UI Payments]
 

Braintree.xcodeproj/project.pbxproj

@@ -4290,6 +4290,7 @@
 			buildSettings = {
 				GCC_PRECOMPILE_PREFIX_HEADER = YES;
 				GCC_PREFIX_HEADER = "$(TARGET_TYPE)/$(PRODUCT_NAME)/Supporting Files/$(PRODUCT_NAME)-Prefix.pch";
+				GCC_WARN_ABOUT_MISSING_NEWLINE = YES;
 				INFOPLIST_FILE = "$(TARGET_TYPE)/$(PRODUCT_NAME)/Supporting Files/$(PRODUCT_NAME)-Info.plist";
 				ONLY_ACTIVE_ARCH = YES;
 				OTHER_CFLAGS = "";
@@ -4304,6 +4305,7 @@
 			buildSettings = {
 				GCC_PRECOMPILE_PREFIX_HEADER = YES;
 				GCC_PREFIX_HEADER = "$(TARGET_TYPE)/$(PRODUCT_NAME)/Supporting Files/$(PRODUCT_NAME)-Prefix.pch";
+				GCC_WARN_ABOUT_MISSING_NEWLINE = YES;
 				INFOPLIST_FILE = "$(TARGET_TYPE)/$(PRODUCT_NAME)/Supporting Files/$(PRODUCT_NAME)-Info.plist";
 				OTHER_CFLAGS = "";
 				PRODUCT_NAME = "$(TARGET_NAME)";

Braintree/API/@Public/BTClient.h

@@ -172,4 +172,4 @@ typedef void (^BTClientFailureBlock)(NSError *error);
                    success:(BTClientCardSuccessBlock)successBlock
                    failure:(BTClientFailureBlock)failureBlock DEPRECATED_MSG_ATTRIBUTE("Please use BTClientCardRequest and saveCardWithRequest:validate:success:failure:");
 
-@end
+@end

Braintree/API/@Public/BTClientCardTokenizationRequest.h

@@ -35,4 +35,4 @@
 /// @return The card request as a dictionary for uploading as parameters in API requests.
 - (NSDictionary *)parameters;
 
-@end
+@end

Braintree/API/App Switch/BTAppSwitchErrors.m

@@ -1,3 +1,3 @@
 #import "BTAppSwitchErrors.h"
 
-NSString *const BTAppSwitchErrorDomain = @"BTAppSwitchErrorDomain";
+NSString *const BTAppSwitchErrorDomain = @"BTAppSwitchErrorDomain";

Braintree/API/Client/API Resources/BTAPIResourceErrors.h

@@ -15,4 +15,4 @@ typedef NS_ENUM(NSInteger, BTAPIResourceErrorCode) {
     BTAPIResourceErrorAPIDictionaryInvalid,
     /// The API Dictionary contains an invalid nested resource
     BTAPIResourceErrorAPIDictionaryNestedResourceInvalid,
-};
+};

Braintree/API/Client/API/BTClientApplePayConfigurationAPI.m

@@ -31,4 +31,4 @@ + (NSDictionary *)APIFormat {
              };
 }
 
-@end
+@end

Braintree/API/Client/BTClientMetadata.h

@@ -29,4 +29,4 @@ typedef NS_ENUM(NSInteger, BTClientMetadataIntegrationType) {
 - (void)setIntegration:(BTClientMetadataIntegrationType)integration;
 - (void)setSource:(BTClientMetadataSourceType)source;
 
-@end
+@end

Braintree/API/Client/BTClientMetadata.m

@@ -82,4 +82,4 @@ - (void)setSource:(BTClientMetadataSourceType)source {
     _source = source;
 }
 
-@end
+@end

Braintree/API/Client/BTClientToken.m

@@ -350,4 +350,4 @@ - (NSString *)btVenmo_status {
     }
 }
 
-@end
+@end

Braintree/API/Models/BTClientCardTokenizationRequest.m

@@ -37,4 +37,4 @@ - (void)safeSetObject:(id)object toDictionary:(NSMutableDictionary *)dictionary
 }
 
 
-@end
+@end

Braintree/API/Models/BTMutableCardPaymentMethod.h

@@ -5,4 +5,4 @@
 
 /// Mutable version of BTCardPaymentMethod.
 @interface BTMutableCardPaymentMethod : BTCardPaymentMethod
-@end
+@end

Braintree/API/Models/BTMutablePayPalPaymentMethod.h

@@ -3,4 +3,4 @@
 
 /// Mutable version of BTPayPalPaymentMethod.
 @interface BTMutablePayPalPaymentMethod : BTPayPalPaymentMethod
-@end
+@end

Braintree/API/Models/BTPaymentMethod.m

@@ -8,4 +8,4 @@ - (NSString *)debugDescription {
     return [NSString stringWithFormat:@"<%@:%p \"%@\" nonce:%@>", NSStringFromClass([self class]), self, [self description], self.nonce];
 }
 
-@end
+@end

Braintree/API/Models/BTPaymentMethod_Mutable.h

@@ -7,4 +7,4 @@
 @property (nonatomic, readwrite, strong) NSSet *challengeQuestions;
 @property (nonatomic, readwrite, copy) NSString *description;
 
-@end
+@end

Braintree/API/Networking/BTHTTPResponse.h

@@ -8,4 +8,4 @@
 
 - (instancetype)initWithStatusCode:(NSInteger)statusCode responseObject:(NSDictionary *)response;
 
-@end
+@end

Braintree/API/Offline Mode/BTOfflineModeURLProtocol.m

@@ -332,4 +332,4 @@ + (void)setBackend:(BTOfflineClientBackend *)backend {
     objc_setAssociatedObject(self, backend_associated_object_key, backend, OBJC_ASSOCIATION_RETAIN_NONATOMIC);
 }
 
-@end
+@end

Braintree/API/Utility/BTKeychain.h

@@ -9,4 +9,4 @@
 + (NSData *)dataForKey:(NSString *)key;
 
 
-@end
+@end

Braintree/Data/DeviceCollectorSDK.h

@@ -144,4 +144,4 @@
  * @result void
  */
 - (void) setDelegate:(id<DeviceCollectorSDKDelegate>) delegate;
-@end // end @interface DeviceCollectorSDK
+@end // end @interface DeviceCollectorSDK

Braintree/Drop-In/BTDropInSelectPaymentMethodViewController.h

@@ -25,4 +25,4 @@
 
 - (void)selectPaymentMethodViewControllerDidRequestNew:(BTDropInSelectPaymentMethodViewController *)viewController;
 
-@end
+@end

Braintree/Drop-In/BTDropInViewController.h

@@ -122,4 +122,4 @@
 /// @param viewController The Drop In view controller informing its delegate
 - (void)dropInViewControllerWillComplete:(BTDropInViewController *)viewController;
 
-@end
+@end

Braintree/Drop-In/Localization/BTDropInLocalizedString.h

@@ -18,4 +18,4 @@
 + (NSString *)ERROR_SAVING_PAYPAL_ACCOUNT_ALERT_MESSAGE;
 + (NSString *)ADD_PAYMENT_METHOD_VIEW_CONTROLLER_TITLE;
 
-@end
+@end

Braintree/PayPal/BTPayPalAppSwitchHandler_Internal.h

@@ -5,4 +5,4 @@
 
 @property (nonatomic, strong, readwrite) BTClient *client;
 
-@end
+@end

Braintree/Payments/@Public/BTPaymentProviderErrors.h

@@ -18,4 +18,4 @@ NS_ENUM(NSInteger, BTPaymentProviderErrorCode) {
 
     /// An error occured creating a Braintree Payment Method from the Apple Pay token
     BTPaymentProviderErrorPaymentMethodCreation,
-};
+};

Braintree/Payments/@Public/Braintree-Payments.h

@@ -1,3 +1,3 @@
 ///  All-in-one import for the Braintree iOS SDK
 
-#import "BTPaymentProvider.h"
+#import "BTPaymentProvider.h"

Braintree/Payments/BTPaymentApplePayProvider_Internal.h

@@ -5,4 +5,4 @@
 + (BOOL)isSimulator;
 - (BOOL)paymentAuthorizationViewControllerCanMakePayments;
 
-@end
+@end

Braintree/Payments/BTPaymentProviderErrors.m

@@ -1,3 +1,3 @@
 #import "BTPaymentProviderErrors.h"
 
-NSString *const BTPaymentProviderErrorDomain = @"BTPaymentProviderErrorDomain";
+NSString *const BTPaymentProviderErrorDomain = @"BTPaymentProviderErrorDomain";

Braintree/UI/Models/BTUICardExpiryFormat.h

@@ -7,4 +7,4 @@
 
 - (void)formattedValue:(NSString * __autoreleasing *)value cursorLocation:(NSUInteger *)cursorLocation;
 
-@end
+@end

Braintree/UI/Views/Apple Pay/BTMockApplePayPaymentAuthorizationViewController.h

@@ -21,4 +21,4 @@
 
 - (void)mockApplePayPaymentAuthorizationViewControllerDidFinish:(BTMockApplePayPaymentAuthorizationViewController *)viewController;
 
-@end
+@end

Braintree/UI/Views/Custom Views/BTUIFormField.h

@@ -30,4 +30,4 @@
 - (void)formFieldDidChange:(BTUIFormField *)formField;
 - (void)formFieldDidDeleteWhileEmpty:(BTUIFormField *)formField;
 
-@end
+@end

Braintree/UI/Views/Custom Views/BTUITextField.h

@@ -18,4 +18,4 @@
 - (void)textField:(BTUITextField *)textField willInsertText:(NSString *)text;
 - (void)textField:(BTUITextField *)textField didInsertText:(NSString *)text;
 
-@end
+@end

Demos/Braintree-API-Demo/BraintreeDemoClientOperation.h

@@ -10,4 +10,4 @@ typedef void (^BraintreeDemoClientOperationDidCompleteBlock)(id, NSError *);
 
 - (void)performWithCompletionBlock:(BraintreeDemoClientOperationDidCompleteBlock)operationDidComplete;
 
-@end
+@end

Demos/Braintree-Demo/Demo Use Case View Controllers/[Braintree braintreeWithClientToken:]/BraintreeDemoBraintreeInitializationDemoViewController.h

@@ -4,4 +4,4 @@
 
 @interface BraintreeDemoBraintreeInitializationDemoViewController : UIViewController
 - (instancetype)initWithCompletion:(void (^)(Braintree *braintree, NSString *currentMerchantName, NSError *error))completionBlock;
-@end
+@end

Demos/Braintree-Demo/Demo Use Case View Controllers/[braintree tokenizeCardWithNumber:expirationMonth:expirationYear:completion:]/BraintreeDemoTokenizationDemoViewController.m

@@ -137,4 +137,4 @@ - (NSString *)tableView:(__unused UITableView *)tableView titleForHeaderInSectio
     return @"Custom Card Form";
 }
 
-@end
+@end

Demos/Braintree-PayPal-Demo/Supporting Files/Braintree-PayPal-Demo-Prefix.pch

@@ -1,3 +1,3 @@
 #import <Availability.h>
 #import <UIKit/UIKit.h>
-#import <Foundation/Foundation.h>
+#import <Foundation/Foundation.h>

Demos/Braintree-UI-Demo/BraintreeDemoPaymentsUIComponentsViewController.h

@@ -1,4 +1,4 @@
 #import <UIKit/UIKit.h>
 
 @interface BraintreeDemoPaymentsUIComponentsViewController : UIViewController
-@end
+@end

Podfile.lock

@@ -91,7 +91,7 @@ EXTERNAL SOURCES:
 
 SPEC CHECKSUMS:
   AFNetworking: 6d7b76aa5d04c8c37daad3eef4b7e3f2a7620da3
-  Braintree: 0f16114efdcd589aa7901b04f9a9571187623607
+  Braintree: fced670cebb1a2deba07461edde061e7227ef0bf
   Expecta: 03aabd0a89d8dea843baecb19a7fd7466a69a31d
   FLEX: 8e53751b915759215d77c7c72b1c7bd28665dac2
   HockeySDK: 27d8b411208f9d3f70c8f6695a8defa2a3465721

Specs/Braintree-API-Integration-Specs/Supporting Files/braintree-api-integration-specs-Prefix.pch

@@ -13,4 +13,4 @@
 #import <OCMock/OCMock.h>
 
 #define HC_SHORTHAND
-#import <OCHamcrest/OCHamcrest.h>
+#import <OCHamcrest/OCHamcrest.h>

Specs/Braintree-API-Specs/BTAPIResourceSpec.m

@@ -293,4 +293,4 @@ + (NSDictionary *)sampleValidAPIDictionaryForTest {
 
 pending(@"API Request object generation");
 
-SpecEnd
+SpecEnd

Specs/Braintree-API-Specs/BTAPIResourceValueTypesSpec.m

@@ -56,4 +56,4 @@ - (void)setBool:(__unused BOOL)value {
     });
 });
 
-SpecEnd
+SpecEnd

Specs/Braintree-API-Specs/BTApplePayPaymentMethodSpec.m

@@ -98,4 +98,4 @@
     });
 });
 
-SpecEnd
+SpecEnd

Specs/Braintree-API-Specs/BTCardSpec.m

@@ -60,4 +60,4 @@
     });
 });
 
-SpecEnd
+SpecEnd

Specs/Braintree-API-Specs/BTClientMetadataSpec.m

@@ -160,4 +160,4 @@
     });
 });
 
-SpecEnd
+SpecEnd

Specs/Braintree-API-Specs/BTClientStoreSpec.m

@@ -92,4 +92,4 @@ + (NSData *)dataForKey:(NSString *)key {
 
 });
 
-SpecEnd
+SpecEnd

Specs/Braintree-API-Specs/BTClientTokenSpec.m

@@ -420,4 +420,4 @@
 
 });
 
-SpecEnd
+SpecEnd

Specs/Braintree-API-Specs/BTHTTPResponseSpec.m

@@ -23,4 +23,4 @@
     expect(response.object).to.equal(@{@"errors": @"Some server error"});
 });
 
-SpecEnd
+SpecEnd

Specs/Braintree-API-Specs/BTLoggerSpec.m

@@ -75,4 +75,4 @@
 
 });
 
-SpecEnd
+SpecEnd

Specs/Braintree-API-Specs/BTMutableCardSpec.m

@@ -83,4 +83,4 @@
     });
 });
 
-SpecEnd
+SpecEnd

Specs/Braintree-API-Specs/BTOfflineModeURLProtocolSpec.m

@@ -92,4 +92,4 @@
     });
 });
 
-SpecEnd
+SpecEnd

Specs/Braintree-API-Specs/BTTestClientTokenFactory.m

@@ -139,4 +139,4 @@ + (NSString *)tokenWithVersion:(NSInteger)version
     }
 }
 
-@end
+@end

Specs/Braintree-API-Specs/BTURLUtilsSpecs.m

@@ -62,4 +62,4 @@
     });
 });
 
-SpecEnd
+SpecEnd

Specs/Braintree-API-Specs/Supporting Files/braintree-api-specs-Prefix.pch

@@ -14,4 +14,4 @@
 
 #import <OHHTTPStubs/OHHTTPStubs.h>
 
-#import "BTSpecHelper.h"
+#import "BTSpecHelper.h"

Specs/Braintree-Data-Specs/Supporting Files/Braintree-Data-Specs-Prefix.pch

@@ -7,4 +7,4 @@
 #define EXP_SHORTHAND
 #import <Expecta/Expecta.h>
 
-#import <OCMock/OCMock.h>
+#import <OCMock/OCMock.h>

Specs/Braintree-PayPal-Integration-Specs/BTPayPalIntegrationSpec.m

@@ -126,4 +126,4 @@
     });
 });
 
-SpecEnd
+SpecEnd

Specs/Braintree-PayPal-Integration-Specs/Supporting Files/Braintree-PayPal-Integration-Specs-Prefix.pch

@@ -12,4 +12,4 @@
 #define HC_SHORTHAND
 #import <OCHamcrest/OCHamcrest.h>
 
-#import <OHHTTPStubs/OHHTTPStubs.h>
+#import <OHHTTPStubs/OHHTTPStubs.h>