Add prune option #48
Merged
Add prune option #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micnncim
requested changes
Oct 29, 2020
pkg/github/github.go
Outdated
| return c.deleteLabel(ctx, owner, repo, currentLabel.Name) | ||
| }) | ||
| } | ||
| if deleteUnManaged { |
There was a problem hiding this comment.
I don't know how to use early return here we need rest of this method
prune option indicate if unmanaged labels should be removed, by default is set to true
slawekjaranowski
force-pushed
the
fix-47
branch
from
19660b4
to
8d4a77e
Compare
micnncim
reviewed
Oct 30, 2020
micnncim
approved these changes
Oct 30, 2020
|
Great work - I appreciate your contributions 😄 |
|
Created the new tag |
|
Thx for approve and new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default behavior was preserved
fix #47