Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: 补充 router 单测，并修复部分失败单测 #627

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

test: 补充 router 单测，并修复部分失败单测 #627

wants to merge 1 commit into from

Conversation

LinFeng1997
Copy link
Contributor

No description provided.

@bailicangdu
Copy link
Member

单测没问题，但源码部分不需要修改

@LinFeng1997
Copy link
Contributor Author

@bailicangdu 这个函数不抽出来没法测，很难 mock。从代码设计上来说其实抽出来也合理，算是 history 相关的方法，也相对于是测试倒推设计了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LinFeng1997 @bailicangdu