Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeoPixel fill is not on V1 #94

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

microbit-matt-hillsdon
Copy link
Contributor

Closes #92

@microbit-matt-hillsdon
Copy link
Contributor Author

I'll try to address translations here with some manual work.

Copy link
Contributor

@microbit-robert microbit-robert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit f31a417 into main Nov 2, 2023
1 check passed
@microbit-matt-hillsdon
Copy link
Contributor Author

image

I've done this on import to Crowdin so need to make manual checks/updates to the kept strings across the supported languages.

@microbit-matt-hillsdon microbit-matt-hillsdon deleted the neopixel-fill-v2 branch November 2, 2023 20:03
@microbit-matt-hillsdon
Copy link
Contributor Author

I've since made a best effort attempt to keep translations in Crowdin. I've dropped proofreading status in non-trivial cases so my work gets some review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NeoPixel doesn't have fill on V1 MicroPython
2 participants