Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stage calculation #1093

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Update stage calculation #1093

merged 1 commit into from
Jan 19, 2023

Conversation

microbit-matt-hillsdon
Copy link
Collaborator

Closes #1092

@github-actions
Copy link

Preview build will be at
https://review-python-editor-v3.microbit.org/fix-prod-stage/

@microbit-matt-hillsdon
Copy link
Collaborator Author 

➜  python-editor-v3 git:(fix-prod-stage) ✗ GITHUB_REF=refs/tags/v3.0.14 node bin/print-ci-env-stage.js
STAGE=PRODUCTION
REACT_APP_STAGE=PRODUCTION
➜  python-editor-v3 git:(fix-prod-stage) ✗ GITHUB_REF=refs/heads/dave node bin/print-ci-env-stage.js
STAGE=REVIEW
REACT_APP_STAGE=REVIEW
➜  python-editor-v3 git:(fix-prod-stage) ✗ GITHUB_REF=refs/heads/main node bin/print-ci-env-stage.js
STAGE=STAGING
REACT_APP_STAGE=STAGING

microbit-robert
microbit-robert approved these changes Jan 19, 2023
View reviewed changes
Copy link
Collaborator

@microbit-robert microbit-robert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit 103a8e0 into main Jan 19, 2023
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the fix-prod-stage branch January 19, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microbit-robert microbit-robert microbit-robert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GHA production builds determine the stage incorrectly
2 participants
@microbit-matt-hillsdon @microbit-robert