Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actions: store reports on failure not success only #1096

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Actions: store reports on failure not success only #1096

merged 1 commit into from
Jan 30, 2023

Conversation

microbit-matt-hillsdon
Copy link
Collaborator

No description provided.

@github-actions
Copy link

Preview build will be at
https://review-python-editor-v3.microbit.org/reports-on-failure/

microbit-robert
microbit-robert approved these changes Jan 26, 2023
View reviewed changes
Copy link
Collaborator

@microbit-robert microbit-robert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm assuming the e2e test failure is due to some flakiness(?) as nothing else has changed.

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit b6ea84d into main Jan 30, 2023
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the reports-on-failure branch January 30, 2023 14:21
@microbit-matt-hillsdon
Copy link
Collaborator Author

LGTM. I'm assuming the e2e test failure is due to some flakiness(?) as nothing else has changed.

Yes, though we need to prioritise looking at this as it's significantly worse since the move to GitHub Actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microbit-robert microbit-robert microbit-robert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@microbit-matt-hillsdon @microbit-robert