Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cmsPreview flag to use alternative CMS dataset #1135

Merged
merged 4 commits into from
Oct 18, 2023

Conversation

microbit-matt-hillsdon
Copy link
Collaborator

@microbit-matt-hillsdon microbit-matt-hillsdon commented Oct 18, 2023

I tried using draft documents but that requires authentication. This way if we copy + publish to preview it's easy to see content changes deep in the tree which would otherwise be awkward as we fetch it all in one go.

Good enough to view new Reference sections assuming they're published
but the top-level document that adds them is a draft.
@github-actions
Copy link

Preview build will be at
https://review-python-editor-v3.microbit.org/drafts-flag/

@microbit-matt-hillsdon microbit-matt-hillsdon changed the title Add a limited drafts flag Add a cmsPrefix flag to use alternative CMS dataset Oct 18, 2023
@@ -48,10 +50,11 @@ interface FlagMetadata {

const allFlags: FlagMetadata[] = [
// Alphabetical order.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah so not so much before 😄

@microbit-matt-hillsdon
Copy link
Collaborator Author

You can now tell this is working as you can see the work-in-progress Neopixels section.

@microbit-matt-hillsdon microbit-matt-hillsdon marked this pull request as ready for review October 18, 2023 13:28
@microbit-matt-hillsdon microbit-matt-hillsdon changed the title Add a cmsPrefix flag to use alternative CMS dataset Add a cmsPreview flag to use alternative CMS dataset Oct 18, 2023
Copy link
Collaborator

@microbit-robert microbit-robert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit 0046f2e into main Oct 18, 2023
1 check passed
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the drafts-flag branch October 18, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants