Add `Hide app icon` option #2462

ILoveOpenSourceApplications · 2024-07-30T15:31:27Z

Adds an option to hide icon from launcher.

Resolves #2263, resolves #2266 as well as resolves #2361.

ale5000-git · 2024-07-30T23:12:32Z

The icon should be enabled by default.

These two should seems to do the opposite:
CheckIn.HIDE_APP_ICON -> getSettingsBoolean(key, true)
android:enabled="false"

ale5000-git · 2024-07-30T23:15:23Z

Also in my opinion the variable name seems a bit strange:
private fun updateHideAppIcon(enabled: Boolean)

Personally I would choose
private fun updateHideAppIcon(hide: Boolean)
or
private fun updateShowAppIcon(enabled: Boolean)

ale5000-git · 2024-07-31T17:48:50Z

The icon should be enabled by default.
android:defaultValue="false"/>

The option in microG settings is disabled so the icon should be enabled by default, but you disable the icon in reality here:
https://github.com/microg/GmsCore/pull/2462/files#diff-d629a5125b2f479f4916b4b963c3ed5bc5b8c8e79951dfb805bc1fa4a7384624R597-R605

        <activity
            android:name="org.microg.gms.ui.MainSettingsActivity"
            android:enabled="false"

Edit: Now that I read better, here you don't disable the icon but the MainSettingsActivity so you actually break the microG settings.
This one mustn't be disabled in any case.

This shouldn't be touched => org.microg.gms.ui.MainSettingsActivity
This can be disabled (but not by default) => org.microg.gms.ui.SettingsActivity

play-services-base/core/src/main/kotlin/org/microg/gms/settings/SettingsProvider.kt

ale5000-git · 2024-07-31T18:06:16Z

Also in my opinion the variable name seems a bit strange: private fun updateHideAppIcon(enabled: Boolean)

May I ask what the variable does here so that I could understand which one from the below two would make sense?

This is just personal opinion but in this case:
updateHideAppIcon(enabled=true)
when enabled = true, the icon is hidden so not enabled.

instead with this:
updateHideAppIcon(hide=true)
when hide = true, the icon is hidden so not enabled.

So actually it is the same in practice but I think the first is just more confusing but it is still personal preference.

@mar-v-in What do you think?

ILoveOpenSourceApplications · 2024-10-02T14:18:16Z

@ale5000-git, I believe I have addressed all the requested changes in this pull request. Please let me know if there are any additional modifications or suggestions.
@mar-v-in, your input would also be greatly appreciated.
Thank you for your time and consideration.

play-services-core/src/main/AndroidManifest.xml

mar-v-in

See my comments on the code. Also, please add a way to hide this setting on the Huawei build flavor, as devices with Huawei OS that support microG, the microG settings is automatically hidden from launcher.

mar-v-in · 2024-10-02T18:40:55Z

play-services-core/src/main/java/org/microg/gms/auth/login/LoginActivity.java

@@ -75,6 +76,7 @@
 import static android.view.View.VISIBLE;
 import static android.view.inputmethod.InputMethodManager.SHOW_IMPLICIT;
 import static org.microg.gms.auth.AuthPrefs.isAuthVisible;
+import static org.microg.gms.checkin.CheckinPreferences.hideAppIcon;


You add new imports without any need. Please remove them again

Even though this PR made changes to play-services-core/src/main/kotlin/org/microg/gms/checkin/CheckinPreferences.kt and play-services-base/core/src/main/kotlin/org/microg/gms/ui/Utils.kt?

mar-v-in · 2024-10-02T18:52:14Z

play-services-core/src/main/res/xml/preferences_start.xml

+            android:icon="@drawable/ic_hide_app_icon"
+            android:key="hideAppIcon"
+            android:summary="@string/pref_hide_app_icon_summary"
+            android:title="@string/pref_hide_app_icon_title" />


Preferences should not be directly modified from the :ui process as shared preferences are not safe for multi-process use. That's why we generally use the SettingsProvider to store settings.

However, in this case, the settings provider is not needed, as the ground truth of the component enabled state is in the PackageManager. With your code, if someone enables or disables the component without using this setting (e.g. by directly invoking pm disable via adb), the setting would no longer match the actual live state.

I suggest you make the setting non-persistent (by settings android:persistent="false") and configure it from code by taking the value from getComponentEnabledSetting when realizing the setting.

mar-v-in · 2024-10-02T18:52:45Z

play-services-core/src/main/res/xml/preferences_start.xml

@@ -65,9 +65,15 @@
            android:title="@string/service_name_location"/>
    </PreferenceCategory>
    <PreferenceCategory android:layout="@layout/preference_category_no_label" android:key="prefcat_footer">
+        <SwitchPreferenceCompat


I don't think this setting is so important that it deserves a prime location at the top level settings dialog. I suggest to create a new section for these kind of things, although I don't know how to name it or what else would belong there.

@mar-v-in
Some ideas:

Other settings

Minor settings

Trivial settings

UI settings

play-services-core/src/main/res/xml/preferences_start.xml

mar-v-in · 2024-10-02T18:54:49Z

play-services-base/core/src/main/kotlin/org/microg/gms/settings/SettingsContract.kt

@@ -34,6 +34,7 @@ object SettingsContract {
        const val SECURITY_TOKEN = "securityToken"
        const val VERSION_INFO = "versionInfo"
        const val DEVICE_DATA_VERSION_INFO = "deviceDataVersionInfo"
+        const val HIDE_APP_ICON = "hideAppIcon"


This does not belong into the Checkin settings contract. In fact it's not needed at all in SettingsContract or SettingsProvider, see my other comment

ale5000-git · 2024-10-02T20:43:07Z

@mar-v-in
I think it would also be nice to be able to optionally set the default status in /system/etc/microg.xml, so ROM authors and flashable ZIPs can set it without the need to mess with it in other ways.

This reverts commit 3094aff.

Add Hide icon from launcher option

81ead92

ILoveOpenSourceApplications changed the title ~~Add Hide icon from launcher option~~ Add Hide app icon option Jul 30, 2024

improve naming

39c349b

ILoveOpenSourceApplications force-pushed the feat/hide-icon branch from 85b2d24 to 39c349b Compare July 30, 2024 16:46

ale5000-git reviewed Jul 31, 2024

View reviewed changes

play-services-base/core/src/main/kotlin/org/microg/gms/settings/SettingsProvider.kt Outdated Show resolved Hide resolved

refactor preferences_start.xml for hide icon

6f4e97f

ILoveOpenSourceApplications force-pushed the feat/hide-icon branch from 75e6627 to 6f4e97f Compare August 1, 2024 07:08

ILoveOpenSourceApplications added 6 commits August 1, 2024 14:03

refactor: Hide app icon

06d6fa6

remove unnecessary change

2b6524a

improve code clarity and maintainability

2f64e62

fix icon color

27488e0

adjust icon thickness

7ea14ed

improve naming

cdefa13

ILoveOpenSourceApplications requested a review from ale5000-git August 4, 2024 13:49

change key value

3094aff

ale5000-git reviewed Oct 2, 2024

View reviewed changes

play-services-core/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved

change state to true

f7ebf66

mar-v-in requested changes Oct 2, 2024

View reviewed changes

ILoveOpenSourceApplications added 2 commits October 3, 2024 12:41

remove unnecessary import

ddacc9c

Revert "change key value"

c1060b1

This reverts commit 3094aff.

ILoveOpenSourceApplications mentioned this pull request Oct 3, 2024

feat: Add a toggle to the Hide launch icon menu ReVanced/GmsCore#39

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `Hide app icon` option #2462

Add `Hide app icon` option #2462

ILoveOpenSourceApplications commented Jul 30, 2024 •

edited

Loading

ale5000-git commented Jul 30, 2024

ale5000-git commented Jul 30, 2024 •

edited

Loading

ale5000-git commented Jul 31, 2024 •

edited

Loading

ale5000-git commented Jul 31, 2024 •

edited

Loading

ILoveOpenSourceApplications commented Oct 2, 2024

mar-v-in left a comment

mar-v-in Oct 2, 2024

ILoveOpenSourceApplications Oct 3, 2024 •

edited

Loading

mar-v-in Oct 2, 2024

mar-v-in Oct 2, 2024

ale5000-git Oct 2, 2024 •

edited

Loading

mar-v-in Oct 2, 2024

ale5000-git commented Oct 2, 2024

Add Hide app icon option #2462

Are you sure you want to change the base?

Add Hide app icon option #2462

Conversation

ILoveOpenSourceApplications commented Jul 30, 2024 • edited Loading

ale5000-git commented Jul 30, 2024

ale5000-git commented Jul 30, 2024 • edited Loading

ale5000-git commented Jul 31, 2024 • edited Loading

ale5000-git commented Jul 31, 2024 • edited Loading

ILoveOpenSourceApplications commented Oct 2, 2024

mar-v-in left a comment

Choose a reason for hiding this comment

mar-v-in Oct 2, 2024

Choose a reason for hiding this comment

ILoveOpenSourceApplications Oct 3, 2024 • edited Loading

Choose a reason for hiding this comment

mar-v-in Oct 2, 2024

Choose a reason for hiding this comment

mar-v-in Oct 2, 2024

Choose a reason for hiding this comment

ale5000-git Oct 2, 2024 • edited Loading

Choose a reason for hiding this comment

mar-v-in Oct 2, 2024

Choose a reason for hiding this comment

ale5000-git commented Oct 2, 2024

Add `Hide app icon` option #2462

Add `Hide app icon` option #2462

ILoveOpenSourceApplications commented Jul 30, 2024 •

edited

Loading

ale5000-git commented Jul 30, 2024 •

edited

Loading

ale5000-git commented Jul 31, 2024 •

edited

Loading

ale5000-git commented Jul 31, 2024 •

edited

Loading

ILoveOpenSourceApplications Oct 3, 2024 •

edited

Loading

ale5000-git Oct 2, 2024 •

edited

Loading