fix(helpers): ensure image is a string (#560)

packages/metascraper-helpers/index.js

@@ -237,7 +237,7 @@ const author = (value, opts) =>
   isAuthor(value) ? getAuthor(value, opts) : undefined
 
 const url = (value, { url = '' } = {}) => {
-  if (isEmpty(value)) return
+  if (!isString(value) || isEmpty(value)) return
 
   try {
     const absoluteUrl = normalizeUrl(url, value)
@@ -344,7 +344,9 @@ const $jsonld = propName => $ => {
 
 const image = (value, opts) => {
   const urlValue = url(value, opts)
-  return !isAudioUrl(urlValue, opts) && !isVideoUrl(urlValue, opts)
+  return urlValue !== undefined &&
+    !isAudioUrl(urlValue, opts) &&
+    !isVideoUrl(urlValue, opts)
     ? urlValue
     : undefined
 }

packages/metascraper-helpers/test/index.js

@@ -11,6 +11,7 @@ const {
   date,
   description,
   extension,
+  image,
   isAudioExtension,
   isAudioUrl,
   isAuthor,
@@ -143,6 +144,21 @@ test('.isVideoUrl', t => {
   t.true(isVideoUrl('https://microlink.io/demo.mp4'))
 })
 
+test('.image', t => {
+  t.is(image('https://microlink.io/demo.png'), 'https://microlink.io/demo.png')
+  t.is(image('/demo.png'), undefined)
+  t.is(
+    image('/demo.png', { url: 'https://microlink.io' }),
+    'https://microlink.io/demo.png'
+  )
+  t.is(image('https://microlink.io/demo.mp4'), undefined)
+  t.is(image('https://microlink.io/demo.mp3'), undefined)
+  t.is(
+    image({ '@id': 'https://www.milanocittastato.it/#/schema/logo/image/' }),
+    undefined
+  )
+})
+
 test('.isImageUrl', t => {
   t.false(isVideoUrl('demo.png'))
   t.false(isVideoUrl('/demo.png'))

packages/metascraper/test/integration/belfusto/index.js

@@ -0,0 +1,31 @@
+'use strict'
+
+const { readFile } = require('fs').promises
+const test = require('ava')
+const { resolve } = require('path')
+
+const metascraper = require('../../..')([
+  require('metascraper-author')(),
+  require('metascraper-date')(),
+  require('metascraper-description')(),
+  require('metascraper-video')(),
+  require('metascraper-image')(),
+  require('metascraper-lang')(),
+  require('metascraper-logo')(),
+  require('metascraper-logo-favicon')(),
+  require('metascraper-manifest')(),
+  require('metascraper-publisher')(),
+  require('metascraper-title')(),
+  require('metascraper-url')(),
+  require('metascraper-readability')()
+])
+
+const url = 'https://www.belfusto.com/tendencia/ergowear/'
+
+test('belfusto', async t => {
+  const html = await readFile(resolve(__dirname, 'input.html'))
+  const metadata = await metascraper({ html, url })
+
+  console.log(metadata)
+  t.snapshot(metadata)
+})