Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map time units to UCUM format for Dynatrace #5589

Merged

Conversation

jonatan-ivanov
Copy link
Member

Closes gh-5588

@jonatan-ivanov
Copy link
Member Author

@pirgeo Could you please confirm that this is not a breaking change for the users?
I.e.: Can one create a dashboard or any component on the Dynatrace UI / use the Dynatrace API responses and will be broken after this change?

/cc @shakuzen

@jonatan-ivanov jonatan-ivanov changed the base branch from main to 1.12.x October 12, 2024 00:59
Copy link
Contributor

@pirgeo pirgeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonatan-ivanov @shakuzen

Could you please confirm that this is not a breaking change for the users?

Confirmed, this change will not break any user. Existing users must trigger the unit upgrade, but new users will already get the UCUM-compliant ones.

@jonatan-ivanov jonatan-ivanov merged commit 9c3b760 into micrometer-metrics:1.12.x Oct 14, 2024
6 checks passed
@jonatan-ivanov jonatan-ivanov deleted the dynatrace-ucum-units branch October 14, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map time units to UCUM format for Dynatrace
3 participants