Cors should use pre-matching request check #11097
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstepanov
commented
Aug 19, 2024
| return Optional.of(HttpStatus.FORBIDDEN); | ||
| if (hasAllowedHeaders(request, config)) { | ||
| List<UriRouteMatch<Object, Object>> anyUriRoutes = router.findAny(request); | ||
| if (anyUriRoutes.isEmpty()) { |
There was a problem hiding this comment.
This is how it worked before, but I think that's not correct. methodToMatchOptional is OPTIONS for preflight check and there is no such method in mocked tests
There was a problem hiding this comment.
methodToMatchOptional can be not OPTIONS if there's a Access-Control-Request-Method header
There was a problem hiding this comment.
Shouldt'n we fail OPTIONS call if there is no route present under that path?
There was a problem hiding this comment.
No, in that case the preflight should return a good response and the actual cors request should return the 404. This will allow the cors client to see that the route is missing. Otherwise it will just get a permission error
|
seems to be failing? |
yawkat
approved these changes
Aug 19, 2024
dstepanov
commented
Aug 20, 2024
|
|
||
| then: | ||
| HttpStatus.OK == response.status() | ||
| HttpStatus.FORBIDDEN == response.status() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.