Implement pcap logging for netty HTTP client #11117
Conversation
The server has supported this for a long time. This PR adds the same feature for client logging. The code is very similar, and the test is basically copied.
|
There was a problem hiding this comment.
Please, mention in https://docs.micronaut.io/4.6.5/guide/#jdkHttpClient that JDK Client implementation does it does not support pcap logging
|
@dstepanov PTAL |
|
| * @return The path pattern, or {@code null} if logging is disabled. | ||
| */ | ||
| @Internal | ||
| public String getPcapLoggingPathPattern() { |
There was a problem hiding this comment.
What's the point of having the accessors internal? People will not see the property configuration as an internal
There was a problem hiding this comment.
the comment is for config users, the annotation is for programmatic users.
The server has supported this for a long time. This PR adds the same feature for client logging. The code is very similar, and the test is basically copied.