Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CORS when used with API versioning. #9512

Merged
merged 6 commits into from
Jul 20, 2023
Merged

Fix CORS when used with API versioning. #9512

merged 6 commits into from
Jul 20, 2023

Conversation

wetted
Copy link
Contributor

@wetted wetted commented Jun 27, 2023

Adding CorsOriginTests for using CORS with @Version to expose issue.

fixes #9375

@wetted wetted self-assigned this Jun 27, 2023
@sdelamo sdelamo added the type: bug Something isn't working label Jun 28, 2023
@wetted wetted linked an issue Jul 11, 2023 that may be closed by this pull request
When using API versioning preflight requests fail with 404 #9375
Closed
@wetted wetted requested a review from yawkat July 19, 2023 17:08
@wetted wetted marked this pull request as ready for review July 19, 2023 17:08
@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

17.5% 17.5% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sdelamo sdelamo merged commit 35ba268 into 3.9.x Jul 20, 2023
9 of 10 checks passed
@sdelamo sdelamo deleted the CORS_and_Versioning_fails_with_404 branch July 20, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yawkat yawkat yawkat approved these changes

Assignees

@wetted wetted

Labels
type: bug Something isn't working
Projects
3.9.5 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When using API versioning preflight requests fail with 404
3 participants
@wetted @yawkat @sdelamo