Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditional eager initializiation of OpenID providers #1108

Closed
wants to merge 1 commit into from
Closed

Conditional eager initializiation of OpenID providers #1108

wants to merge 1 commit into from

Conversation

adamkobor
Copy link

Provides a better workaround for: #604

@adamkobor adamkobor mentioned this pull request Oct 4, 2022
Closed
@adamkobor adamkobor force-pushed the feature/eager-init-of-openid-clients branch from cd8ec64 to 74ace82 Compare November 10, 2022 16:12
@adamkobor
Copy link
Author

kindly pinging @sdelamo regard this PR :)

@sdelamo
Copy link
Contributor

sdelamo commented Nov 11, 2022

kindly pinging @sdelamo regard this PR :)

I have this on top of my queue for monday. Thanks for the patience @adamkobor

@adamkobor
Copy link
Author

kindly pinging @sdelamo regard this PR :)

I have this on top of my queue for monday. Thanks for the patience @adamkobor

np, thanks for the heads up and also have a nice weekend!

@sdelamo
Copy link
Contributor

sdelamo commented Nov 15, 2022

this PR is related to #868

@sdelamo
Copy link
Contributor

sdelamo commented Nov 16, 2022 •
edited
Loading

@adamkobor , I think using @Parallel and @Context is a better solution to avoid blocking the Netty event loop. Thanks for raising this PR and pushing us towards finding a solution.

@sdelamo sdelamo closed this Nov 16, 2022
@adamkobor
Copy link
Author

@adamkobor , I think using @Parallel and @Context is a better solution to avoid blocking the Netty event loop. Thanks for raising this PR and pushing us towards finding a solution.

No problem, I'm glad if I could help a bit :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdelamo sdelamo Awaiting requested review from sdelamo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamkobor @sdelamo