bump up to Serde M4 #1304
bump up to Serde M4 #1304
Conversation
As recommended by the gradle documentation https://docs.gradle.org/current/userguide/performance.html#execute_tests_in_parallel This makes the test less brittle when running ./gradlew test --parallel
| @@ -16,7 +16,7 @@ bcpkix = "1.70" | |||
| micronaut-test = "4.0.0-M3" | |||
| micronaut-multitenancy = "5.0.0-M2" | |||
| micronaut-reactor = "3.0.0-M1" | |||
| micronaut-serde = "2.0.0-M1" | |||
| micronaut-serde = "2.0.0-M4" | |||
There was a problem hiding this comment.
Serde M4 includes micronaut-projects/micronaut-serialization#439 Thanks for the quick fix @yawkat
| @@ -156,22 +159,54 @@ class ClientCredentialsConcurrentSpec extends Specification { | |||
| this.tokenExpiration = tokenExpiration | |||
| } | |||
|
|
|||
|
|
|||
| @Introspected | |||
| static class ClientCredentialsForm { | |||
There was a problem hiding this comment.
I had to extract this POJO to make the test pass with serde 4
There was a problem hiding this comment.
I created an issue in serde micronaut-projects/micronaut-serialization#441
| void "no exception for concurrent requests using client credentials"() { | ||
| when: | ||
| int numberOfFutures = Runtime.getRuntime().availableProcessors() - 1 | ||
| int numberOfFutures = Runtime.runtime.availableProcessors().intdiv(2) ?: 1 |
There was a problem hiding this comment.
I am borrowing a page from Gradle Execute tests in parallel documentation. This makes this test pass when running in parallel (./gradlew test --parallel). I have a 10 machine and Runtime.runtime.availableProcessors() returns 20.
This reverts commit 22535a4.
|
Kudos, SonarCloud Quality Gate passed!
|
No description provided.