Change method names. Remove synchronization. Remove use of streams #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskleeh
commented
Nov 23, 2021
security-jwt/src/main/java/io/micronaut/security/token/jwt/signature/jwks/JwksSignature.java
Show resolved
Hide resolved
sdelamo
added a commit
that referenced
this pull request
Nov 23, 2021
* build: project version to 3.2.0-SNAPSHOT * ci: github core branch to 3.2.x * build: bump micronaut-gradle-plugins from 4.1.5 to 4.2.1 (#815) Bumps [micronaut-gradle-plugins](https://github.com/micronaut-projects/micronaut-build) from 4.1.5 to 4.2.1. - [Release notes](https://github.com/micronaut-projects/micronaut-build/releases) - [Commits](micronaut-projects/micronaut-build@v4.1.5...v4.2.1) --- updated-dependencies: - dependency-name: io.micronaut.build.internal:micronaut-gradle-plugins dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build: bump reactor-test from 3.4.10 to 3.4.11 (#814) Bumps [reactor-test](https://github.com/reactor/reactor-core) from 3.4.10 to 3.4.11. - [Release notes](https://github.com/reactor/reactor-core/releases) - [Commits](reactor/reactor-core@v3.4.10...v3.4.11) --- updated-dependencies: - dependency-name: io.projectreactor:reactor-test dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build: bump testcontainers from 1.16.0 to 1.16.2 (#822) Bumps [testcontainers](https://github.com/testcontainers/testcontainers-java) from 1.16.0 to 1.16.2. - [Release notes](https://github.com/testcontainers/testcontainers-java/releases) - [Changelog](https://github.com/testcontainers/testcontainers-java/blob/master/CHANGELOG.md) - [Commits](testcontainers/testcontainers-java@1.16.0...1.16.2) --- updated-dependencies: - dependency-name: org.testcontainers:testcontainers dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build: bump micronaut-gradle-plugins from 4.2.1 to 4.2.2 (#821) Bumps [micronaut-gradle-plugins](https://github.com/micronaut-projects/micronaut-build) from 4.2.1 to 4.2.2. - [Release notes](https://github.com/micronaut-projects/micronaut-build/releases) - [Commits](micronaut-projects/micronaut-build@v4.2.1...v4.2.2) --- updated-dependencies: - dependency-name: io.micronaut.build.internal:micronaut-gradle-plugins dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: improve JWKS caching Close: #771 * Update gradle.properties * Update test * build: micronaut gradle plugins to 4.2.3 * checkstyle: fix checkstyle * add javadoc * handle key rotation of authorization server * fix checkstyle * test no kid * sort signature configuration based on kid match * remove recursion * add JWKS cache expiration * simplify code * better javadoc * add nullability annotations * Update security-jwt/src/main/java/io/micronaut/security/token/jwt/signature/jwks/JwksCache.java Co-authored-by: Steven Brown <[email protected]> * Update security-jwt/src/main/java/io/micronaut/security/token/jwt/signature/jwks/JwksSignature.java Co-authored-by: Steven Brown <[email protected]> * javadoc: remove recursive call * remove recursive mention from javadoc * flag methods with synchronized and volatile fields * better docs for default value * Change method names. Remove synchronization. Remove use of streams (#853) * fix checkstyle * fix test Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Steven Brown <[email protected]> Co-authored-by: James Kleeh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.