Updated Tags for consistency, need to check LB.ps1 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Christopher, We use VSCode too, but regarding the trailing spaces our VSCode wont report that. I believe is related to "Line Sequence" configuration or some add-on. Load Balancer Module is one of the modules that were not very optimized yet, that's why I believe it uses the old style of processing tags. Thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the tagging routines in the Modules directory to be consistent.
Note that I'm using VSCode for this, and one of the artifacts of that is a general clean-up of code (removing trailing spaces) hence the large diff on some files.
The LoadBalancer.ps1 script uses inconsistent tag blocks, but I need to build and test before I can commit a PR.
Thanks!