Fix bug: rotateToYaw not working #2516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songxiaocheng
force-pushed
the
PR/rotate_to_yaw
branch
from
258e5e4
to
85493ec
Compare
Make it consistent with other API.
- `isYawWithinMargin` should receive the target yaw degree as the first argument - the original stop criterion does not stop rotation due to inertia, so the resulted yaw is not guaranteed.
madratman
force-pushed
the
PR/rotate_to_yaw
branch
from
85493ec
to
4115e0a
Compare
|
Works well. Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1682, #856
Changes to fix
rotateToYaw:isYawWithinMarginshould receive the target yaw degree as the first argumentBy the way, the
rotateByYawRateimplementation were made consistent with other API.