Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simDisableActor API #2561

Closed
wants to merge 3 commits into from
Closed

Add simDisableActor API #2561

wants to merge 3 commits into from

Conversation

rajat2004
Copy link
Contributor

@rajat2004 rajat2004 commented Apr 10, 2020 •
edited
Loading

Mentioned in #2552
My first try with UE-specific coding, so things would probably be wrong 😅

Based on https://unrealcpp.com/hide-and-disable-actor/, https://docs.unrealengine.com/en-US/API/Runtime/Engine/GameFramework/AActor/index.html and some forum posts

@rajat2004 rajat2004 changed the title [UE] Add disableActor API function Add simDisableActor API Apr 10, 2020
@rajat2004 rajat2004 mentioned this pull request Apr 10, 2020
Open
@rajat2004 rajat2004 force-pushed the disable-actor branch 3 times, most recently from e5f6cb1 to c9ea024 Compare April 11, 2020 10:16
@rajat2004 rajat2004 marked this pull request as ready for review April 12, 2020 14:58
@rajat2004
Copy link
Contributor Author

rajat2004 commented Apr 12, 2020 •
edited
Loading

Tested this to be working properly on Linux, with the simulation working properly after simDisableActor() was called. Object doesn't occur in the visual rendering and no collision as well

Thoughts:
Object still appears in the list when simListSceneObjects is called. Should this be removed?
Add enableActor() API? This might lead to it being called on things which haven't been disabled, or maybe something new also

Will need to look into whether the above both things can be done or not
Edit: enableActor() should be easily doable, since it would just need the reverse of the bool arguments to the UE functions

@rajat2004 rajat2004 closed this Apr 13, 2020
@rajat2004 rajat2004 reopened this Apr 13, 2020
@rajat2004
Copy link
Contributor Author

Rebased on master

@rajat2004 rajat2004 mentioned this pull request May 3, 2020
Merged
@rajat2004
Copy link
Contributor Author

Closing this in favour of #2651
FYI @madratman

@rajat2004 rajat2004 closed this May 4, 2020
@rajat2004 rajat2004 mentioned this pull request May 17, 2020
Closed
@rajat2004 rajat2004 mentioned this pull request May 27, 2020
Closed
@rajat2004 rajat2004 deleted the disable-actor branch August 4, 2021 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rajat2004