fix: compile on Ubuntu 21.10 and Unreal 4.27.2 #4365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work for ROS2 UE4 Camera Pub [sc-2974]
|
|
zimmy87
suggested changes
May 18, 2022
Comment on lines
+111
to
+113
| // needed when packaging | ||
| // PublicAdditionalLibraries.Add("stdc++"); | ||
| // PublicAdditionalLibraries.Add("supc++"); |
There was a problem hiding this comment.
commented out code should be deleted; it can be found in source history if need be
| @@ -38,17 +38,17 @@ else #linux | |||
| software-properties-common \ | |||
| wget \ | |||
| libvulkan1 \ | |||
| vulkan-utils | |||
| vulkan-tools | |||
There was a problem hiding this comment.
this change in dependencies is breaking the ubuntu 18.04 build:
+ sudo apt-get -y install --no-install-recommends lsb-release rsync software-properties-common wget libvulkan1 vulkan-tools
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package vulkan-tools
Error: Process completed with exit code 100.
Can you make this logic conditional or change it to a dependency that both ubuntu 21.10 and 18.04 share?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #
About
How Has This Been Tested?
Successfully compiled on the machine described above.
Screenshots (if appropriate):