-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve EventCounter name #1341
Comments
Yes. This should have been the right way instead of esname|counter. Or as you suggested, this must be an opt-in flag. |
Shall I give it a go in a PR, by using an opt-in flag? |
@Expecho Yes we are happy to get a contribution! |
I've started the work. As a reminder: after and if changes are merged we should update the docs: https://docs.microsoft.com/en-us/azure/azure-monitor/app/eventcounters |
How about (optionally) using the MetricNamespace property of a MetricTelemetry to store the eventsource name? As I understand the namespace property is there to group metrics together. (source). I don't really like the pipe character to make a distinction between the eventsource name and the eventcounter name.
Related to microsoft/ApplicationInsights-dotnet-server#1226
The text was updated successfully, but these errors were encountered: