Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve EventCounter name #1341

Closed
Expecho opened this issue Oct 24, 2019 · 4 comments
Closed

Improve EventCounter name #1341

Expecho opened this issue Oct 24, 2019 · 4 comments

Comments

@Expecho
Copy link
Contributor

Expecho commented Oct 24, 2019

How about (optionally) using the MetricNamespace property of a MetricTelemetry to store the eventsource name? As I understand the namespace property is there to group metrics together. (source). I don't really like the pipe character to make a distinction between the eventsource name and the eventcounter name.

Related to microsoft/ApplicationInsights-dotnet-server#1226

@TimothyMothra TimothyMothra transferred this issue from microsoft/ApplicationInsights-dotnet-server Dec 4, 2019
@cijothomas
Copy link
Contributor

Yes. This should have been the right way instead of esname|counter.
Unfortunately we may not be able to fix this as some cx may have taken a dependency on this name.

Or as you suggested, this must be an opt-in flag.

@Expecho
Copy link
Contributor Author

Expecho commented Apr 10, 2020

Yes. This should have been the right way instead of esname|counter.
Unfortunately we may not be able to fix this as some cx may have taken a dependency on this name.

Or as you suggested, this must be an opt-in flag.

Shall I give it a go in a PR, by using an opt-in flag?

@cijothomas
Copy link
Contributor

@Expecho Yes we are happy to get a contribution!

@Expecho
Copy link
Contributor Author

Expecho commented Apr 21, 2020

I've started the work. As a reminder: after and if changes are merged we should update the docs: https://docs.microsoft.com/en-us/azure/azure-monitor/app/eventcounters

@cijothomas cijothomas added this to the 2.15 milestone Apr 21, 2020
cijothomas pushed a commit that referenced this issue Apr 22, 2020
…EventSource name in the MetricNamespace (#1804)

* Adresses issue #1341

* Updated changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants