Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Duration from string to TimeSpan in autogenerated internal class. #927

Closed
cijothomas opened this issue Oct 1, 2018 · 0 comments
Closed
Assignees
Milestone

Comments

@cijothomas
Copy link
Contributor

DependencyTelemetry has a public field Duration of type TimeSpan. This field is served by a string field leading to conversion between String and TimeSpan throughout the system.
https://github.com/Microsoft/ApplicationInsights-dotnet/blob/develop/src/Microsoft.ApplicationInsights/DataContracts/DependencyTelemetry.cs#L216

Proposal is to change the internal auto-generated code (https://github.com/Microsoft/ApplicationInsights-dotnet/blob/develop/Schema/PublicSchema/RemoteDependencyData.bond#L27) to use TimeSpan to avoid conversion between String and TimeSpan.

Applicable to DependencyTelemetry and RequestTelemetry.

Version Info

SDK Version :
.NET Version :
How Application was onboarded with SDK(VisualStudio/StatusMonitor/Azure Extension) :
OS :
Hosting Info (IIS/Azure WebApps/ etc) :

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant