Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding sourcelink to projects, and refactor csproj #1859

Merged
merged 1 commit into from
May 7, 2020
Merged

Adding sourcelink to projects, and refactor csproj #1859

merged 1 commit into from
May 7, 2020

Conversation

eddynaka
Copy link
Contributor

@eddynaka eddynaka commented May 5, 2020

Fix Issue #1760 .

See comment history on original PR: #1800

Changes

  • refactor csproj, moving Analyzers and Build dependencies into Product.props
  • Adding package reference to Microsoft.SourceLink.GitHub

Checklist

  • I ran Unit Tests locally.
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed

The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.

Notes for authors:

  • FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.

Notes for reviewers:

  • We support comment build triggers
    • /AzurePipelines run will queue all builds
    • /AzurePipelines run <pipeline-name> will queue a specific build

@azure-pipelines
Copy link

There was an error handling pipeline event c95ccd48-beb8-4edd-a372-274b6da3401c.

@eddynaka
Copy link
Contributor Author

eddynaka commented May 5, 2020

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@TimothyMothra
Copy link
Member

I would like to propose a change to this:

Can you add the following snippet to this file: .props\Product.props


  <ItemGroup Condition=" $(OS) == 'Windows_NT' And $(Configuration) == 'Release'">
    <!--Analyzers-->
    <PackageReference Include="Desktop.Analyzers" Version="1.1.0">
      <PrivateAssets>All</PrivateAssets>
    </PackageReference>
    <PackageReference Include="StyleCop.Analyzers" Version="1.1.118">
      <PrivateAssets>All</PrivateAssets>
    </PackageReference>
    <PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="2.9.8">
      <PrivateAssets>All</PrivateAssets>
    </PackageReference>
    <PackageReference Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="2.9.8">
      <PrivateAssets>All</PrivateAssets>
    </PackageReference>

    <!--Build Infrastructure-->
    <PackageReference Include="Microsoft.VisualStudioEng.MicroBuild.Core" Version="0.4.1">
      <PrivateAssets>All</PrivateAssets>
    </PackageReference>
    <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0">
      <PrivateAssets>all</PrivateAssets>
      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
    </PackageReference>
  </ItemGroup>

Then, can you please remove all of these references from each of the 17 csproj files?

IM me on Teams if you have questions.

adding debugtype as portable to check symbols

removing os condition

update changelog for removing netstandard 1.x (#1858)

since we are using msbuild, we have to set deterministic

reverting

updating Product.props and removing reference from all projects

adding sourceroot based on github issue (dotnet/roslyn#37379)

including pdbs in output folder

commenting deterministic properties and sourceroot

removing cibuild from nugetprops

undoing nupkg and sourceroot from directory.build
@TimothyMothra TimothyMothra changed the title [WIP] Adding sourcelink to projects Adding sourcelink to projects, and refactor csproj May 7, 2020
@TimothyMothra TimothyMothra merged commit d1865fc into microsoft:develop May 7, 2020
@TimothyMothra TimothyMothra mentioned this pull request Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants