Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PoC] Support for Redfield #2348

Closed
wants to merge 9 commits into from
Closed

[PoC] Support for Redfield #2348

wants to merge 9 commits into from

Conversation

TimothyMothra
Copy link
Member

@TimothyMothra TimothyMothra commented Jul 30, 2021

Changes

  • Introduce build flag Redfield=True
  • When detected, change version of dependency: System.Diagnostics.DiagnosticSource
  • When detected set a Constant to be used in preprocessor. This is used to change the name of EventSource.

To use:

dotnet build /p:Redfield=True

To verify:

I introduced a new unit test to verify that these changes took effect.

dotnet build /p:Redfield=True ".\dotnet\BASE\Microsoft.ApplicationInsights.sln"
dotnet test ".\bin\Debug\test\Microsoft.ApplicationInsights.Tests\net5.0\Microsoft.ApplicationInsights.Tests.dll" --filter Name~VerifyRedfieldEventSourceName

Open Questions

  • Do we need to run full tests against Redfield build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant