Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TelemetryConfiguration configurable in ApplicationInsightsLoggingBuilderExtensions #2552

Merged
merged 6 commits into from
Mar 10, 2022

Conversation

TimothyMothra
Copy link
Member

@TimothyMothra TimothyMothra commented Mar 10, 2022

Fix Issue #1944.
Supersedes PR #1643.

Changes

  • expose method to allow users to configure the full TelemetlyConfiguration object in ApplicationInsightsLoggingBuilderExtensions. This provides a mechanism to configure the ConnectionString which is now the recommended way to configure Application Insights resources.
  • fix link in Readme
  • update code sample in Readme to demonstrate setting ConnectionString

Checklist

  • I ran Unit Tests locally.
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed

The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.

Notes for authors:

  • FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.

Notes for reviewers:

  • We support comment build triggers
    • /AzurePipelines run will queue all builds
    • /AzurePipelines run <pipeline-name> will queue a specific build

@TimothyMothra TimothyMothra enabled auto-merge (squash) March 10, 2022 17:32
@TimothyMothra TimothyMothra merged commit ed0015a into main Mar 10, 2022
@TimothyMothra TimothyMothra deleted the tilee/ilogger_config branch March 10, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants