Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Azure.Cosmos.Requests source #2789

Merged
merged 4 commits into from
Aug 7, 2023

Conversation

lmolkova
Copy link
Member

@lmolkova lmolkova commented Jun 16, 2023

Changes

Cosmos DB team does not want to report transport calls via Application Insights. This PR ignores corresponding source and only listens to Azure.Cosmos.Operation

Checklist

  • I ran Unit Tests locally.
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

@TimothyMothra
Copy link
Member

@lmolkova is this ready for review? The PR is still a Draft.

@TimothyMothra
Copy link
Member

Please update the changelog.

@lmolkova lmolkova marked this pull request as ready for review July 18, 2023 22:08
@lmolkova
Copy link
Member Author

thank you @TimothyMothra, I updated the changelog!
It is ready for review.

@sourabh1007 please approve if you're fine with the changes.

Copy link
Member

@TimothyMothra TimothyMothra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmolkova
Copy link
Member Author

lmolkova commented Aug 4, 2023

Thanks @sourabh1007 for the review!

@TimothyMothra I belive it's ready to be merged if you're still fine with it. Thank you!

@TimothyMothra TimothyMothra merged commit 1769773 into microsoft:main Aug 7, 2023
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants