Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3326][JS,TS] Update Teams sample 58 to use SendMessageToTeamsChannelAsync #3705

Merged
merged 1 commit into from
Apr 21, 2022
Merged

[#3326][JS,TS] Update Teams sample 58 to use SendMessageToTeamsChannelAsync #3705

merged 1 commit into from
Apr 21, 2022

Conversation

sw-joelmut
Copy link
Collaborator

Fixes #3326

Note: We created the issue botbuilder-js#4144 to fix the problem when the sendMessageToTeamsChannel is executed, it doesn't return the new conversation reference.

Description

This PR updates the JavaScript and TypeScript Teams 58 samples to use the TeamsInfo.sendMessageToTeamsChannel method when the onMessage is executed.

Detailed Changes

  • Replaces the manual creation of a conversation using the TeamsInfo.SendMessageToTeamsChannelAsync method instead.

Testing

The following images show the bot working, but responding the message to a different conversation.
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner March 4, 2022 17:46
@johnataylor johnataylor merged commit b51d79f into main Apr 21, 2022
@johnataylor johnataylor deleted the southworks/update/js-ts-teams-sample-58 branch April 21, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnataylor johnataylor johnataylor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Teams sample 58
2 participants
@sw-joelmut @johnataylor