fix: Remove the unused lufiles in notifications (#1760)

* Remove the unused lufiles in notifications * fix e2e test
microsoft · Dec 11, 2019 · 2abb4cb · 2abb4cb
1 parent f8bfd6d
commit 2abb4cb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/Composer/cypress/integration/NotificationPage.spec.ts b/Composer/cypress/integration/NotificationPage.spec.ts
@@ -4,7 +4,7 @@
 context('Notification Page', () => {
   beforeEach(() => {
     cy.visit(Cypress.env('COMPOSER_URL'));
-    cy.createBot('TodoSample');
+    cy.createBot('ToDoBotWithLuisSample');
     cy.visitPage('Notifications');
   });
 
@@ -31,7 +31,7 @@ context('Notification Page', () => {
   it('can show lu syntax error ', () => {
     cy.visitPage('User Input');
 
-    cy.get('.dialogNavTree button[title="__TestTodoSample.Main"]').click({ multiple: true });
+    cy.get('.dialogNavTree button[title="__TestToDoBotWithLuisSample.Main"]').click({ multiple: true });
 
     cy.get('.toggleEditMode button').click();
     cy.get('textarea').type('test lu syntax error');
@@ -45,18 +45,18 @@ context('Notification Page', () => {
         .click();
     });
 
-    cy.findAllByText('__TestTodoSample.Main').should('exist');
+    cy.findAllByText('__TestToDoBotWithLuisSample.Main').should('exist');
   });
 
   it('can show dialog expression error ', () => {
     cy.visitPage('Design Flow');
 
     cy.findByTestId('ProjectTree').within(() => {
-      cy.findByText('Greeting').click();
+      cy.findByText('WelcomeUser').click();
     });
 
     cy.withinEditor('VisualEditor', () => {
-      cy.findByText('Greeting').should('exist');
+      cy.findByText('WelcomeUser').should('exist');
     });
 
     cy.withinEditor('FormEditor', () => {
@@ -73,6 +73,6 @@ context('Notification Page', () => {
         .click();
     });
 
-    cy.findAllByText('Greeting').should('exist');
+    cy.findAllByText('WelcomeUser').should('exist');
   });
 });
diff --git a/Composer/packages/client/src/pages/notifications/useNotifications.tsx b/Composer/packages/client/src/pages/notifications/useNotifications.tsx
@@ -8,6 +8,7 @@ import { StoreContext } from '../../store';
 import { replaceDialogDiagnosticLabel } from '../../utils';
 
 import { INotification, DiagnosticSeverity } from './types';
+import { getReferredFiles } from './../../utils/luUtil';
 
 export default function useNotifications(filter?: string) {
   const { state } = useContext(StoreContext);
@@ -28,7 +29,7 @@ export default function useNotifications(filter?: string) {
         });
       });
     });
-    luFiles.forEach(lufile => {
+    getReferredFiles(luFiles, dialogs).forEach(lufile => {
       lufile.diagnostics.map(diagnostic => {
         const location = `${lufile.id}.lu`;
         notifactions.push({