Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger names #1911

Closed
zxyanliu opened this issue Jan 28, 2020 · 10 comments
Closed

Trigger names #1911

zxyanliu opened this issue Jan 28, 2020 · 10 comments
Assignees

Comments

@zxyanliu
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Current naming of triggers is a bit confusing.

image

Describe the solution you'd like

Screen Shot 2020-01-21 at 4 09 28 PM

@zxyanliu zxyanliu added the Needs-triage A new issue that require triage label Jan 28, 2020
@mareekuh
Copy link
Contributor

mareekuh commented Jan 30, 2020

Screen Shot 2020-02-03 at 6 30 46 PM

Updated design: https://www.figma.com/file/HLtKaKHctLldivPnzQ7BqQOI/Composer-MI---lotsotings?node-id=2108%3A13658

(also addresses other issues with usability/discoverability for Trigger types but I cannot find that).

@hibrenda hibrenda added Type: Enhancement and removed Needs-triage A new issue that require triage labels Feb 4, 2020
@hibrenda
Copy link
Contributor

hibrenda commented Feb 4, 2020

Need more clarification and also need to address the RecognizerSet as well .

@zxyanliu
Copy link
Contributor Author

@mareekuh FYI. You might have already found this in the trigger menu:

I think the first trigger type in the Message events drop-down menu should be Message received. What is shown now is

Message events
-> Message events
-> Message deleted
-> Message reaction
-> Message updated

What it is supposed to be:

Message events
-> Message received
-> Message deleted
-> Message reaction
-> Message updated

Untitled

Thanks.

@mareekuh
Copy link
Contributor

Yes : Message received vs Message Events
The dropdown should not have the word 'events' in it, per our discussion.
Trigger type: Language understanding/Dialog/Message/Other activities/Custom. Yes?

@zxyanliu
Copy link
Contributor Author

zxyanliu commented Feb 19, 2020

Hey @mareekuh
I agree that the word 'events' should be removed from some of the drop-down menus.
However, I also think it might be helpful to keep 'events' in the first-level menu. Thanks to @boydc2014 who explained "events" and "triggers" to me so that I have a better understanding of the two terms.

Here are my rough thoughts:

What initiates the trigger?
-> Recognizer events
-> Dialog events
-> Message activity events
-> Other activity events
-> Custom event

The major reason to include events in the first-level menu is that it might help users to understand that triggers are created to react to some type of events.

Thanks.

@mareekuh
Copy link
Contributor

mareekuh commented Feb 21, 2020

No I'd like to leave out the word event.
Select a trigger type:
Intent (the 2nd field should show all existing intents and 'create new' at the top)
Not recognized intent (2nd field is empty)
Dialog trigger
Message activity
Other activity
Custom trigger

https://www.figma.com/file/HLtKaKHctLldivPnzQ7BqQOI/Composer-MI-lotsotings?node-id=2663%3A15274

@zxyanliu
Copy link
Contributor Author

zxyanliu commented Feb 21, 2020

@mareekuh It looks good! Just one thing, can we add the word "trigger" to each of them? I feel it's more consistent. But this will bring another issue, some trigger names may be too long.

@mareekuh
Copy link
Contributor

mareekuh commented Feb 21, 2020

We can use 'trigger' in the first menu, but don't need it again in the 2nd.

@zxyanliu
Copy link
Contributor Author

zxyanliu commented Feb 21, 2020

Yes, I agree. No need to duplicate in the 2nd level menu.

@cwhitten
Copy link
Member

cwhitten commented Mar 9, 2020

addressed via #2151

@cwhitten cwhitten closed this as completed Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants