fix: trigger creation bug #2151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liweitian
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
liweitian
force-pushed
the
trggerCreationBugFix
branch
from
556dc2a
to
3baabd1
Compare
|
can you add a gif? how did you add regex back? |
alanlong9278
force-pushed
the
trggerCreationBugFix
branch
from
0a5aee8
to
d584c7d
Compare
…otFramework-Composer into trggerCreationBugFix
…otFramework-Composer into trggerCreationBugFix
…otFramework-Composer into trggerCreationBugFix
cwhitten
approved these changes
Mar 9, 2020
|
nice work @liweitian & @alanlong9278 ! |
This was referenced Mar 9, 2020
Closed
zhixzhan
reviewed
Mar 10, 2020
|
|
||
| set(content, path, current); | ||
| export function createNewTrigger(dialog: DialogInfo, data: TriggerFormData): DialogInfo { |
There was a problem hiding this comment.
The return type DialogInfo I believe is an indexed dialog type, but here you didn't
reindex it, and seems no need to reindex it. So I would suggest return content: string.
|
|
||
| return content; | ||
| export function createRegExIntent(dialog: DialogInfo, intent: string, pattern: string): DialogInfo { |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Task Item
Closes #2193
Closes #2158
Closes #1911
Screenshots