Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: allow running composer in hosted mode for tests #1356

Merged
merged 3 commits into from
Nov 22, 2019
Merged

test: allow running composer in hosted mode for tests #1356

merged 3 commits into from
Nov 22, 2019

Conversation

p-nagpal
Copy link
Contributor

@p-nagpal p-nagpal commented Oct 30, 2019 •
edited by a-b-r-o-w-n
Loading

Description

Allow Composer to run in hosted mode on a local dev box (for testing). Changes:

  1. Use a single flag COMPOSER_AUTH_PROVIDER to detect if this is hosted mode.
    2.PUBLIC_URL is not set when running locally - to allow the composer and bot project to run as separate sites (localhost:3978/9 and localhost:3000)
  2. If hostname is localhost, then dont assume bot endpoint is at http://{hostname}.

Task Item

refs #1344

Type of change

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have functionally tested my change

@a-b-r-o-w-n a-b-r-o-w-n changed the title Allow running composer in hosted mode for tests test: allow running composer in hosted mode for tests Nov 22, 2019
@github-actions
Copy link

Coverage Status

Coverage decreased (-0.007%) to 39.838% when pulling 8cd29c0 on user/ponagpal/abslocalTest into 7e84f05 on master.

@a-b-r-o-w-n a-b-r-o-w-n merged commit 1904471 into master Nov 22, 2019
@a-b-r-o-w-n a-b-r-o-w-n deleted the user/ponagpal/abslocalTest branch November 22, 2019 22:29
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
Merged
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@hailiu2586 hailiu2586 Awaiting requested review from hailiu2586

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p-nagpal @a-b-r-o-w-n