Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Trigger Node #1529

Merged
merged 40 commits into from
Nov 29, 2019
Merged

feat: Trigger Node #1529

merged 40 commits into from
Nov 29, 2019

Conversation

yeze322
Copy link
Contributor

@yeze322 yeze322 commented Nov 7, 2019

Description

image

Task Item

closes #1437

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code refactor (non-breaking change which improve code quality, clean up, add tests, etc)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Doc update (document update)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have functionally tested my change

Screenshots

Please include screenshots or gifs if your PR include UX changes.

@yeze322 yeze322 changed the title Trigger Node [WIP] Trigger Node Nov 7, 2019
@yeze322
Copy link
Contributor Author

yeze322 commented Nov 7, 2019

We need to finalize what's the exact content (grey text) shown in trigger text of each trigger type
image

image

Collected some details from design:

Trigger Type Name to show (black) Label to show (grey)
Intent $designer.name > ? (Intent trigger)
Unrecognized intent $designer.name > ? (Unrecognized intent trigger)
Dialog trigger $designer.name > ? ?
Activity trigger $designer.name > ? ?
Message activity trigger $designer.name > ? ?
Custom trigger $designer.name > ? ?

@mareekuh
Copy link
Contributor

mareekuh commented Nov 7, 2019

Please show the sub-trigger type name vs the overarching trigger : this is not only more informative, it also removed the repeat of the word 'trigger'.
So for user input this would be Intent or 'not recognized intent'
And for Dialog Triggers

  • Dialog started (BeginDialog)
  • Dialog cancelled (CancelDialog)
  • Error occurred
  • Re-prompt for input

For Activity Trigger:

  • Conversation started (ConversationUpdate)
  • Conversation ended
  • Handover to human
  • Conversation invoked
  • User is typing
  • Event received

and for message activity:

  • Message received
  • Message updated
  • Message deleted
  • Message reaction (thumbs up/down)

Custom trigger can remain Custom trigger.

@yeze322 yeze322 changed the title [WIP] Trigger Node feat: Trigger Node Nov 14, 2019
@yeze322
Copy link
Contributor Author

yeze322 commented Nov 18, 2019

fixed broken test cases

@cwhitten
Copy link
Member

@yeze322 we should roll up the form changes into this PR.

Copy link
Member

@cwhitten cwhitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yeze322 let's include the form changes in this PR

@github-actions
Copy link

Coverage Status

Coverage increased (+0.02%) to 39.86% when pulling 91eea69 on zeye/design/trigger into 2f96b52 on master.

@yeze322
Copy link
Contributor Author

yeze322 commented Nov 22, 2019

@a-b-r-o-w-n @alanlong9278 could you help rolling up the Form part's changes? I'm not quite familiar with it, thanks!

image
We need one more subtitle in the form editor which leverages the ConceptLabels map

@yeze322
Copy link
Contributor Author

yeze322 commented Nov 27, 2019

Thanks Chris for updating those titles, let me fix CI failures.

@lei9444 lei9444 mentioned this pull request Nov 29, 2019
9 tasks
@boydc2014 boydc2014 merged commit 70e13ef into master Nov 29, 2019
@boydc2014 boydc2014 deleted the zeye/design/trigger branch November 29, 2019 03:41
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants