Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add ability to configure runtime path #1713

Merged
merged 10 commits into from
Dec 9, 2019
Merged

build: add ability to configure runtime path #1713

merged 10 commits into from
Dec 9, 2019

Conversation

a-b-r-o-w-n
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n commented Dec 6, 2019 •
edited
Loading

refs #1669

  • Fixes issue when creating bots in docker.
  • Adds a very simple e2e health check that starts docker compose and hits localhost:3000

I attempted to run the build on all platforms but mac and windows had errors (unrelated to the docker-compose bit itself).

@github-actions
Copy link

github-actions bot commented Dec 6, 2019

Coverage Status

Coverage increased (+0.02%) to 40.967% when pulling 54e326b on docker-windows into 797900e on master.

@a-b-r-o-w-n a-b-r-o-w-n marked this pull request as ready for review December 6, 2019 19:58
@boydc2014
Copy link
Contributor

Looks good, verified on my side and on @liweitian.

@boydc2014 boydc2014 merged commit 7677101 into master Dec 9, 2019
@boydc2014 boydc2014 deleted the docker-windows branch December 9, 2019 09:09
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
Merged
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boydc2014 boydc2014 boydc2014 approved these changes

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-b-r-o-w-n @boydc2014