feat: link to tab #1738
Merged
feat: link to tab #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lei9444
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
a-b-r-o-w-n
reviewed
Dec 9, 2019
|
|
||
| export * from './parsePathToFocused'; | ||
| export * from './parsePathToSelected'; | ||
| export * from './parseTypeToFragment'; |
There was a problem hiding this comment.
Are these meant to be shared in other packages? I would expect these to live in the client.
| export function parseTypeToFragment(type: string, property: string): string { | ||
| const inputTypes = dialogGroups[DialogGroup.INPUT].types; | ||
| const index = inputTypes.findIndex(t => t === type); | ||
| if (index >= 0) { |
There was a problem hiding this comment.
Suggested change
| if (index >= 0) { | |
| if (inputTypes.find(t => t === type)) { |
| const index = inputTypes.findIndex(t => t === type); | ||
| if (index >= 0) { | ||
| if (property === 'property') return PromptTab.USER_INPUT; | ||
| if (property === 'prompt') return PromptTab.BOT_ASKS; |
There was a problem hiding this comment.
I'm worried about this scaling to all fields. Not sure what to do about it, but we should start thinking on how to handle this.
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the url generate function to support the link to INPUT tab.
refs #1667
Type of change
Please delete options that are not relevant.
Checklist
Screenshots