-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a11y: Use header tag for trigger in visual editor #2128
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanlong9278
requested review from
a-b-r-o-w-n,
benbrown,
boydc2014,
cwhitten and
yeze322
as code owners
February 28, 2020 13:22
yeze322
suggested changes
Feb 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Ashish described in the issue by saying 'defined under heading tag' should be using <h1>/<h2>/<hi>
instead of using span
alanlong9278
changed the title
chore: Add tag for trigger in visual editor
chore: Use header tag for trigger in visual editor
Feb 29, 2020
Fixed it. |
yeze322
approved these changes
Mar 2, 2020
cwhitten
approved these changes
Mar 4, 2020
cwhitten
changed the title
chore: Use header tag for trigger in visual editor
ally: Use header tag for trigger in visual editor
Mar 4, 2020
corinagum
changed the title
ally: Use header tag for trigger in visual editor
a11y: Use header tag for trigger in visual editor
Mar 5, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use header tag for trigger in visual editor
Task Item
fixes #2028
Screenshots