Some missing types at directline.d.ts

[bivas6]

Hi,
I'm using directline in my app, and I noticed some missing types:

1. This code:

  this._directLine = new DirectLine(options);
  this._directLine.activity$
    .subscribe((activity) => console.log(activity.replyToId))

Returns this error:

  Property 'replyToId' does not exist on type 'Message'.ts(2339)

But it is exist in the docs: https://docs.microsoft.com/en-us/dotnet/api/microsoft.bot.schema.activity.replytoid?view=botbuilder-dotnet-stable

2. This code:

  this._directLine.postActivity({  type: 'endOfConversation', text: '...' , ...});

Returns this error:

Type '"endOfConversation"' is not assignable to type '"message" | "event" | "typing"'.ts(2322)
directLine.d.ts(271, 5): The expected type comes from property 'type' which is declared here on type 'Activity'

But it is exist in the docs: https://docs.microsoft.com/en-us/dotnet/api/microsoft.bot.schema.activitytypes.endofconversation?view=botbuilder-dotnet-stable

Thanks!

[mdrichardson]

@bivas6 botframework-directlinejs doesn't implement the full schema as the rest of DirectLine. You can see what is included here.

As a workaround, you can suppress the error and still send your activity with any type or replyToId; once the typescript code is converted to javascript, there isn't any type checking that goes on, so you can still send the activity with the "normal" schema

Something like this:

//@ts-ignore: Activity Schema is valid for DirectLine, but not the botframework-directline package
this._directLine.postActivity({ type: 'endOfConversation' })

@compulim Is there a reason this doesn't include all DL schema? If you like, I can submit a PR that covers this.

[vishwacsena]

DirectLineJS is a browser client on DirectLine and will not support the full DirectLine schema. That said, we will evaluate the interface we expose to see if we should add or remove any existing types and will report back.

[cwhitten]

Hi @bivas6, we'll take an item in our upcoming milestone to update the types exposed.

[bivas6]

Thanks @cwhitten

[cwhitten]

@bivas6 we were unable to complete this in our current sprint. Moving to next sprint.

[orgads]

@cwhitten ping

[cwhitten]

Currently in our upcoming milestone (March 2021)

[carlosscastro]

@compulim @cwhitten is this on track to release in R13?

[orgads]

ping?

[orgads]

This can be closed. type was changed to string.