Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot Framework Emulator - Audio card -image is not displaying. #3315

Open
rvinothrajendran opened this issue Jul 19, 2020 · 12 comments
Open

Bot Framework Emulator - Audio card -image is not displaying. #3315

rvinothrajendran opened this issue Jul 19, 2020 · 12 comments
Assignees
Labels
backlog Out of scope for the current iteration but it will be evaluated in a future release. blocked currently prevented from making progress Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. ExemptFromDailyDRIReport exempt from daily DRI report external-directlinejs front-burner p1 Painful if we don't fix, won't block releasing

Comments

@rvinothrajendran
Copy link

Version

4.9.0

Describe the bug

Audio card -image is not displaying.

Steps to reproduce

Try the Audio Card sample with image.

Expected behavior

Image should be display

Screenshots

image

@rvinothrajendran rvinothrajendran added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete. labels Jul 19, 2020
@stevkan stevkan assigned stevkan and v-kydela and unassigned stevkan Jul 20, 2020
@v-kydela
Copy link

Thank you for the report, @rvinothrajendran

Would you kindly link to the sample you're referring to, and provide some code that reproduces the issue?

@v-kydela v-kydela added the customer-replied-to Required for internal reporting. Do not delete. label Jul 21, 2020
@rvinothrajendran
Copy link
Author

@v-kydela
Copy link

v-kydela commented Jul 22, 2020

@compulim - I have confirmed that audio card images do not render in Web Chat or Emulator, and it's not because of the SVG. JPG images also do not render. (This has nothing to do with the bot being written in Python, of course.) I will transfer this to you.

@v-kydela v-kydela assigned compulim and unassigned v-kydela Jul 22, 2020
@daveta
Copy link

daveta commented Aug 3, 2020

@compulim : Any updates?

@peterinnesmsft
Copy link
Contributor

@compulim are you able to take a look into this one?

@compulim
Copy link
Contributor

compulim commented Sep 1, 2020

I believe this is a feature we missed.

@compulim compulim added Enhancement and removed bug Indicates an unexpected problem or an unintended behavior. labels Sep 1, 2020
@tdurnford
Copy link
Contributor

tdurnford commented Sep 14, 2020

@v-kydela Web Chat is equipped to handle Audio Cards with images; however, DirectLineJs is not. microsoft/BotFramework-DirectLineJS#180

@tdurnford tdurnford assigned tonyanziano and unassigned compulim Sep 14, 2020
@tonyanziano
Copy link
Contributor

So to clarify, @tdurnford, Web Chat currently supports this with Bots connected via DirectLine?

If that's the case, there's basically a lack of parity here between Emulator and Web Chat and the ask would be to implement images with audio cards in the Emulator?

@tdurnford
Copy link
Contributor

@tonyanziano Not quite. If Web Chat receives an Audio Card with an image, it will render the poster correctly. However, if the bot sends an Audio Card with an image and it is sent through DirectLine, DirectLine will remove the image. Web Chat/DirectLineJs and the Emulator current exhibit the same behavior.

Additional Context

<AudioContent autoPlay={autostart} loop={autoloop} poster={imageURL} src={url} />

@corinagum corinagum added this to the R12 milestone Sep 30, 2020
@corinagum corinagum added the backlog Out of scope for the current iteration but it will be evaluated in a future release. label Oct 5, 2020
@corinagum corinagum modified the milestones: R12, Backlog Oct 5, 2020
@corinagum corinagum added bug Indicates an unexpected problem or an unintended behavior. and removed feature-request Azure report label labels Oct 5, 2020
@cwhitten cwhitten modified the milestones: Backlog, R12 Nov 9, 2020
@corinagum
Copy link
Contributor

I believe this is blocked by microsoft/BotFramework-DirectLineJS#180, confirm?
Mark DLJS issue as bug?
Assigning to @Kaiqb for visibility

@corinagum corinagum added the blocked currently prevented from making progress label Jan 13, 2021
@corinagum corinagum assigned Kaiqb and unassigned tonyanziano Jan 13, 2021
@corinagum corinagum added Area: DLJS p1 Painful if we don't fix, won't block releasing labels Jan 13, 2021
@corinagum corinagum removed this from the R12 milestone Jan 20, 2021
@compulim
Copy link
Contributor

@corinagum this is also related to microsoft/BotFramework-DirectLineJS#255.

@carlosscastro
Copy link
Member

@compulim I see that microsoft/BotFramework-DirectLineJS#255 is scheduled to ship on R13. ASsuming that is the case, would this be also addressed in R13?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Out of scope for the current iteration but it will be evaluated in a future release. blocked currently prevented from making progress Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. ExemptFromDailyDRIReport exempt from daily DRI report external-directlinejs front-burner p1 Painful if we don't fix, won't block releasing
Projects
None yet
Development

No branches or pull requests