-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the Emulator user to specify a User ID #1422
Conversation
Pull Request Test Coverage Report for Build 2369
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…/Microsoft/BotFramework-Emulator into feature/southworks/choose-userId
…/Microsoft/BotFramework-Emulator into feature/southworks/choose-userId
packages/app/client/src/ui/editor/appSettingsEditor/appSettingsEditor.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! 🎉
Thanks! 🎉 |
This reverts commit 2c6a4cf.
Hi @Aliandi and @denscollo: Justin's in-flight work in #1400 had problems reconciling with some of the changes made in this diff, so we reverted it in the hopes that when his branch lands @Aliandi can reissue the pull request against master again. |
@denscollo @Aliandi this is ready to be re-opened against master. There has been a refactor to some of the code-paths involved so some changes will be necessary. |
Fixes #1344
Description
This PR allows the Emulator users to specify a User ID which will be used within conversations.
Changes made
Functionality changes
To implement this feature we made the following changes:
UI Changes
Before
After
Testing
Manual testing
Automated testing
Added automated tests for the new settings options.