Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue where conversation restart was using a new port every time. #1434

Merged
merged 1 commit into from
Apr 19, 2019

Conversation

tonyanziano
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2415

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 56.798%

Totals Coverage Status
Change from base Build 2410: 0.01%
Covered Lines: 5235
Relevant Lines: 8665

💛 - Coveralls

@cwhitten cwhitten merged commit d5f1dac into jwilaby/auto-connect-emulator Apr 19, 2019
@cwhitten cwhitten deleted the toanzian/jwilaby-fix branch April 19, 2019 21:04
cwhitten pushed a commit that referenced this pull request Apr 22, 2019
* Middleware and Emulator config for auto-connecting bot

* Changed Connector API to use X headers for bot related info

* 1. Completed 'sidecard' debug mode\n2. Added renderers for trace activities so webchat displays them\n3. Added a dendrogram json viewer

* Added the new 'Bot State Visualizer' extension and wired it up

* Completed diffing for bot state objects

* Updated unit tests

* Added unit tests - lint fixes

* Rebase adjustments

* Integrated 'deep-diff' library

* Added switching between Graph and Json views

* Corrected errant inport

* Moved the valueType for the bot state to a const

* Simplified the chat panel. Fixed #1387

* Updated selection of messages in WebChat when trace activities are rendered

* Cured divergent schemas and aligned with the botbuilder-schema package

* Updated errant import from rebase

* Added inspecable log items for the nested activities that come with the traces

* Mapped highlighing in the log to either traces or nested activities within the trace

* Lint fixes

* Build fix

* Applied color treatment to json viewer for bot state diffing

* Update packages/emulator/core/src/facility/conversationSet.ts

Co-Authored-By: justinwilaby <[email protected]>

* fixed #1285. Fixed #825. Added collapsed service pane when in debug mode

* Unit test remediation

* Unit test fixes

* Unit test corection

* Updated code to fix breaking changes when moving to electron 4

* Attempt to fix unit tests run on the build server

* Fixed issue where conversation restart was using a new port every time. (#1434)

* Fixed issue where conversation update was not being sent when opening a livechat via url. (#1436)

* Remove showInInspector from the JSON object before sending it to the JSON inspector (#1437)

* Drill livechat mode (#1438)

* Allows injection of Conversation "mode" to support conversations started via connecting by url.

* Clean up the types

* Fix a test

* Save transcript fix (#1440)

* Changes to support saving a transcript for a conversation opened via url

* add tests for getTranscriptsPath

* Lint issue

* Add some additional typings

* Lint fixes

* Disabled the restart conversation button when in sidecard debug mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants