Fixed click handling within all adaptive card inputs. #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyanziano
requested review from
a-b-r-o-w-n,
compulim,
corinagum and
cwhitten
as code owners
tonyanziano
force-pushed
the
toanzian/cards-fix
branch
from
571f28e
to
1bc5fab
Compare
cwhitten
previously approved these changes
Jul 17, 2019
tonyanziano
force-pushed
the
toanzian/cards-fix
branch
from
e662a03
to
9077400
Compare
cwhitten
approved these changes
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1680 & #1683
===
To ensure that all Adaptive Card inputs (in Web Chat) are handled properly, I took the sample card JSON found on the "Inputs" page in the Adaptive Cards docs, and added logic to handle all the inputs rendered from that JSON.
The following elements should now be handled as well as all other input tag elements (date pickers, number pickers, etc):
NOTE: At points in the gif it looks like I'm interacting with invisible UI elements (when using the date picker / dropdown). That's because my screen recorder was unable to record floating UI elements for whatever reason.