Fixed bug where opening a chat via url was sending two conversation u… #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyanziano
requested review from
a-b-r-o-w-n,
compulim,
corinagum and
cwhitten
as code owners
tonyanziano
force-pushed
the
toanzian/convo-update
branch
from
38a1654
to
67b2e8b
Compare
compulim
previously approved these changes
Aug 16, 2019
tonyanziano
force-pushed
the
toanzian/convo-update
branch
from
67b2e8b
to
142391a
Compare
stevengum
approved these changes
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pdates.
This was only happening when opening a bot via url for the first time. Any conversation restarts after that, or opening a livechat via .bot file were working as intended.
Addresses #1689
===
membersAddedarray to be consistent with line 73 in the same fileBefore the fix:
After the fix: