[#1792] Fixed issue with transcripts path input. #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyanziano
requested review from
a-b-r-o-w-n,
compulim,
corinagum and
cwhitten
as code owners
tonyanziano
force-pushed
the
toanzian/acc-#1792
branch
from
1a3c147
to
6c4d4d4
Compare
tonyanziano
force-pushed
the
toanzian/acc-#1792
branch
from
6c4d4d4
to
cd8c12e
Compare
tonyanziano
force-pushed
the
toanzian/acc-#1792
branch
from
cd8c12e
to
eedd596
Compare
corinagum
approved these changes
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1792
Fixes #1260
===
The transcripts path input field in the resource settings dialog was not editable even though it was marked as editable. This was an accessibility issue for people using screen reader technologies as well as a bug.
There was also a bug where selecting a new transcripts path by using the browse button was not resolving the promise correctly, producing
[object object]within the text field.Before:
After: