Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1796] Fixed accessibility issue with collapsible area in endpoint dialog. #1842

Merged
merged 1 commit into from
Sep 6, 2019

Conversation

tonyanziano
Copy link
Contributor

#1796

===

The collapsible region was not reading expanded / collapsed state when using a screen reader, now it reads the state properly:

"Azure bot service configuration button (expanded | collapsed)"

I also fixed the markup and styling.

Before:

image

After:

image

@coveralls
Copy link

coveralls commented Sep 5, 2019

Coverage Status

Coverage increased (+0.002%) to 65.767% when pulling b067a56 on toanzian/acc-#1796 into 4e3fab1 on master.

corinagum
corinagum previously approved these changes Sep 6, 2019
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants