#1744 Fix Restart conversation menu #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corinagum
requested review from
a-b-r-o-w-n,
compulim,
cwhitten and
tonyanziano
as code owners
tonyanziano
reviewed
Sep 6, 2019
|
We go back-and-forth, then back-and-forth again. Almost rewrote it. But we finally figured out it should be So many work and think process, so little showing in this PR. |
tonyanziano
previously approved these changes
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1750
This PR tweaks the "Restart conversation" menu items in the chat view.
Please note: this component has been updated from 'listbox' role to 'menu' role.
Semantically, the behavior we want to emulate more closely matches the menu bar. For an accessible example, please see w3.org menubar2
This fix returns focus to the caret (next to Restart conversation button) after an action has been selected from the submenu.
Below is the transcribed behavior when navigating the toolbar that contains Restart Conversation.
When focused on "Restart conversation menu":
Enter : NVDA says: "Restart with new user ID 1 of 2"
↓ : NVDA says "Restart with same user ID 2 of 2"
Enter : NVDA says "Restart conversation submenu 2 of 3"
Below is an animated gif of the behavior using keyboard navigation.